E2E_Tests_CI_FIX #85
Merged
E2E_Tests_CI_FIX #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarbu15
approved these changes
Nov 7, 2024
src/env_vars.py
Outdated
| @@ -26,7 +27,7 @@ def get_env_var(var_name, default=None): | |||
| IP_RANGE = get_env_var("IP_RANGE", "172.18.0.0/24") | |||
| GATEWAY = get_env_var("GATEWAY", "172.18.0.1") | |||
| RUNNING_IN_CI = get_env_var("CI") | |||
| API_REQUEST_TIMEOUT = get_env_var("API_REQUEST_TIMEOUT", 20) | |||
| API_REQUEST_TIMEOUT = get_env_var("API_REQUEST_TIMEOUT", 50) | |||
There was a problem hiding this comment.
Sometimes I got error that REST isn't ready or connection timeout this could be my machine but I added it just to avoid it happening on CI but I can remove it
There was a problem hiding this comment.
I would prefer to remove this change as this could make the CI slow if we end up with a lot of requests timing out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
This PR has 3 tests for E2E
1-test_filter_20_senders_1_receiver
NOTE: for NODE_2 = GO-WAKU 20 nodes also tested and works fine
2-test_filter_3_senders_multiple_msg_1_receiver
1- 4 nodes started with relay = true
2- node 4 is filter node
3- node5 makes filter request and marks node4 as filter node
4- 3 nodes publish messages_num*3 messages (each publish messages_num)
5- node 5 makes filter inquiry to get published messages
6. check is done to confirm receiving of messages_num messages
3-test_filter_many_subscribed_nodes
1- 2 nodes started with relay = true
2- node 2 is filter node
3- "max_subscribed_nodes" are created and making node2 as their filter node
4- node 1 publish message
5- the "max_subscribed_nodes" inquiry the published messages
6- check is done to ensure each node receives 1 message
NOTE: for NODE_2 = GO-WAKU "max_subscribed_nodes" nodes also tested and works fine
Additional changes
1- Adding flag --max-connections=1000 at file waku_node.py to increase number of connected peers
2- Adding var stress_enabled at env_vars.py when this var = true some limits in number of nodes will increase to allow
extensive testing
Issues reported: